zeroshade commented on code in PR #2075:
URL: https://github.com/apache/iceberg-go/pull/2075#discussion_r4168212784
##########
table/table.go:
##########
@@ -1423,6 +1427,21 @@ func WithLabels(l *iceberg.Labels) Option {
}
}
+// WithSavedConfig supplies a set of properties used to create a *Table
Review Comment:
Nit: please document the contract from the thread here and on
`SavedConfig()`. The map holds table-scoped FileIO config only, never catalog
props or credentials. It is visible to anyone who holds the table, and the REST
refresh layers it between the catalog props and the vended creds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
