rdblue commented on code in PR #17541: URL: https://github.com/apache/iceberg/pull/17541#discussion_r4169508449
########## core/src/test/java/org/apache/iceberg/TestRootManifestFile.java: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import java.nio.ByteBuffer; +import org.apache.iceberg.inmemory.InMemoryInputFile; +import org.apache.iceberg.io.InputFile; +import org.junit.jupiter.api.Test; + +class TestRootManifestFile { + private static final long SNAPSHOT_ID = 42L; + private static final long SEQUENCE_NUMBER = 7L; + private static final long FIRST_ROW_ID = 1000L; + private static final byte[] CONTENTS = new byte[] {1, 2, 3, 4, 5}; + private static final String LOCATION = "s3://bucket/db/table/metadata/root.parquet"; + + private final InputFile file = new InMemoryInputFile(LOCATION, CONTENTS); + + @Test + void exposesFileMetadata() { + RootManifestFile root = + new RootManifestFile( + file, SNAPSHOT_ID, SEQUENCE_NUMBER, FIRST_ROW_ID, /* keyMetadata= */ null); + + assertThat(root.path()).isEqualTo(LOCATION); + assertThat(root.length()).isEqualTo(CONTENTS.length); + assertThat(root.snapshotId()).isEqualTo(SNAPSHOT_ID); + assertThat(root.sequenceNumber()).isEqualTo(SEQUENCE_NUMBER); + assertThat(root.firstRowId()).isEqualTo(FIRST_ROW_ID); + } + + @Test + void readableAsAV4DataManifest() { Review Comment: This test name doesn't make sense. I would expect it to instantiate a `V4ManifestReader` given the name, but that isn't something that should be tested here. I think this is intended to check fields that are defaulted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
