linhongyu510 commented on PR #3145: URL: https://github.com/apache/iceberg-rust/pull/3145#issuecomment-5968282713
Follow-up on the CHANGES_REQUESTED round. Head is now `ea27138a9` (merged latest `main`; the prior merge conflict is resolved). **Addressed:** - `FileScanTaskDeleteFile` deserialization now routes through a `FileScanTaskDeleteFileSerde` mirror that builds via `builder().build()`, so a task rebuilt from a serialized scan plan passes `validate()` like a manifest-built task — a malformed plan now fails at deserialize time instead of reaching a loader `expect`. - Enforced the spec pairing rule for **every** delete-file kind: `content_size_in_bytes` is required whenever `content_offset` is present (previously only deletion vectors). - Replaced two duplicate builder-only tests in `delete_file_index.rs` with one that drives the missing-coordinate check through `get_deletes_for_data_file`. - Reworded PR-history-laden comments to describe the code as it is now. **Tests:** `cargo test -p iceberg --lib` → 1846 passed, 0 failed; `cargo clippy -p iceberg --lib` clean; `cargo fmt` done. Mergeable state moved from `dirty` to `blocked` (only required reviews/checks remain). Not requesting approval — awaiting re-review when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
