Copilot commented on code in PR #3337: URL: https://github.com/apache/iceberg-rust/pull/3337#discussion_r4178324077
########## .github/copilot-instructions.md: ########## @@ -19,3 +19,14 @@ When reviewing pull requests, follow these rules to avoid noise and redundancy: - First-time contributors: For users new to this repository, explicitly instruct them to "Please check and address all review comments in this PR." + +Also flag these, once per PR with the locations: + +- Comment churn: Code comments or docs that restate the code, narrate + history, or justify review decisions. +- Unrelated edits: Renames, reformatting, or reordering of code the + change does not otherwise need. +- API growth: New `pub` items with no use outside the crate (see + `public-api.txt`). Suggest `pub(crate)`. Review Comment: In a library, an intended downstream API often has no in-workspace caller, so “no use outside the crate” is not evidence that `pub` is excessive. This criterion can incorrectly request `pub(crate)` for legitimate API additions; base the check on whether downstream exposure is intended or justified by the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
