ShivanshhhG commented on PR #17914: URL: https://github.com/apache/iceberg/pull/17914#issuecomment-5991160828
Hi @yangshangqing95, Following up on your review feedback: I have updated `doesNotReuseSignedComponentAcrossSignerClients` into a full end-to-end behavioral regression test: 1. Client 1 issues a sign request for an S3 resource; the mock signer returns a cacheable response (`Cache-Control: private`) with signature `AWS4-HMAC-SHA256 sig-client-1`. 2. A repeated sign request through Client 1 hits its local cache without dispatching an additional remote sign request (`callCount == 1`). 3. Client 2 (representing a separate principal / client instance) issues an identical request (same HTTP method, AWS region, and URI). It verifies that Client 2 calls its own signer, does not reuse Client 1's cached signature, and receives `AWS4-HMAC-SHA256 sig-client-2` (`callCount == 2`). 4. Subsequent calls on Client 2 hit Client 2's cache. 5. In addition, `assertThat(client1.signedComponentCache()).isNotSameAs(client2.signedComponentCache())` verifies structural cache instance isolation. All tests and spotless checks pass cleanly. Ready for another review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
