Zain-ul-Abdin45 commented on PR #3809: URL: https://github.com/apache/iceberg-python/pull/3809#issuecomment-5994683149
I verified this locally against current `main`. It merges cleanly, and `mkdocs build --strict` passes. I also ran both new snippets end to end against a `SqlCatalog`: - delete + append inside `tbl.transaction()` land in a single catalog commit - `update_schema()` + append in one transaction adds the column and writes the row in one commit - raising inside the `with` block leaves the table untouched `tbl.upsert(...)` produced 3 snapshots in one atomic commit for an update+insert, so the softened wording from @Fokko's review is accurate. LGTM. @Fokko @kevinjqliu, this still needs an approval from someone with write access. Could one of you take a final look before the stale bot closes it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
