zakariya-s commented on code in PR #2932:
URL: https://github.com/apache/iceberg-rust/pull/2932#discussion_r4185331338
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -1470,7 +1478,7 @@ impl SessionCatalog for RestSessionCatalog {
};
let file_io = self
- .load_file_io(Some(&response.metadata_location), None)
+ .load_file_io(commit.identifier(),
Some(&response.metadata_location), None)
Review Comment:
Initially I did reuse the FileIO while I was drafting the PR, but noticed
that #2651 already does this via `Table::with_file_io` in `do_commit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
