David-Banquet commented on issue #941: URL: https://github.com/apache/iceberg-rust/issues/941#issuecomment-5997952913
A status check on `main`, since the code has moved since this was opened. The original concern is mostly gone: the Glue catalog no longer infers its FileIO from `warehouse`, it builds it from the storage factory and the catalog properties. The only remaining use of `warehouse` is the default table location in `create_table`, and only when the Glue database has no `LocationUri` (`get_default_table_location` in `utils.rs`). What still differs from Java is when the check happens. `GlueCatalogBuilder::load` fails with "Catalog warehouse is required" before any call to Glue. Java's `GlueCatalog` accepts a missing warehouse and only throws in `defaultWarehouseLocation`, when a table is created without a location in a database that has no `LocationUri`. So a read-only client, or one that always creates tables in databases with a location, works in Java without a warehouse and is refused in Rust. @blackmwk I see #3102 keeps the fail-fast validation on purpose. Would you take a follow-up that moves the check to `create_table`, matching Java? If so I can open it once #3102 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
