unikdahal commented on PR #3291: URL: https://github.com/apache/iceberg-rust/pull/3291#issuecomment-6000552003
> Would it be simpler to return DeleteVector directly, or add something like into_delete_vector()? That would also avoid having a second public type for a set of deleted positions (u64 in DeleteVector, i64 here). Yeah, avoiding a position-by-position rebuild for the rewrite path is a fair point. I’m less sure that exposing "DeleteVector" is the right API though, especially with the DV work still in progress in #3232 / #2580. I’d keep this PR scoped to the loader and decide the bulk transfer/merge API alongside that work or the rewrite integration, once the right shape is clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
