danielcweeks commented on code in PR #17912:
URL: https://github.com/apache/iceberg/pull/17912#discussion_r4197288823
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -461,7 +464,14 @@ private void refreshStorageCredentials() {
return;
}
- try (VendedCredentialsProvider provider =
VendedCredentialsProvider.create(properties)) {
+ Map<String, String> refreshProperties = Maps.newHashMap(properties);
Review Comment:
I don't feel like this is the right place to configure this. It seems like
a better place is in the RESTSessionCatalog when we process the storage
credentials and configure the FileIO. This isn't specific to S3FileIO, so
finding the right place up the stack would make more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
