mbutrovich commented on code in PR #3354:
URL: https://github.com/apache/iceberg-rust/pull/3354#discussion_r4198174015
##########
crates/iceberg/src/avro/schema.rs:
##########
@@ -975,6 +989,10 @@ mod tests {
}
#[test]
+ #[ignore = "apache-avro 0.22 drops `logicalType: map` when parsing schema
JSON \
Review Comment:
> Before taking the bump I'd add a test that writes a manifest and asserts
its header `avro.schema` still contains `"logicalType":"map"`.
[`test_write_manifest_header_marks_int_keyed_maps`](https://github.com/apache/iceberg-rust/blob/91486882b29deb0d97560543e0764aa00a2988fd/crates/iceberg/src/spec/manifest/writer.rs#L886-L902)
does this. It counts `"logicalType":"map"` in the written file and expects
six, one for each metrics map. The writer never parses its schema, so the
attribute that apache/avro-rs#654 drops on parse survives.
[`test_schema_with_array_map_without_parsing`](https://github.com/apache/iceberg-rust/blob/91486882b29deb0d97560543e0764aa00a2988fd/crates/iceberg/src/avro/schema.rs#L1031-L1058)
replaces the ignored test's coverage of the array-map conversion. It converts
maps with `boolean` keys and optional and required values from Iceberg to Avro
and back, on a schema built in code. #3360 tracks removing the `#[ignore]` once
a release includes apache/avro-rs#656.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
