sungwy commented on code in PR #4082:
URL: https://github.com/apache/iceberg-python/pull/4082#discussion_r4198567537
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1624,13 +1624,13 @@ def _field_id(self, field: pa.Field) -> int:
def _get_column_projection_values(
file: DataFile,
- projected_schema: Schema,
+ projected_field_ids: set[int],
table_schema: Schema,
partition_spec: PartitionSpec | None,
file_project_field_ids: set[int],
) -> dict[int, Any]:
- """Apply Column Projection rules to File Schema."""
- project_schema_diff =
projected_schema.field_ids.difference(file_project_field_ids)
+ """Resolve missing identity partition values for output and filter
columns."""
+ project_schema_diff =
projected_field_ids.difference(file_project_field_ids)
Review Comment:
nit: since this is no longer derived from the projected schema, maybe rename
to match the new param?
```suggestion
missing_field_ids =
projected_field_ids.difference(file_project_field_ids)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
