RussellSpitzer opened a new issue, #3365: URL: https://github.com/apache/iceberg-rust/issues/3365
### Is your feature request related to a problem or challenge? A snapshot committed by iceberg-rust records the operation and file metrics, and nothing that identifies the writer. On a table that several engines commit to, that snapshot cannot be distinguished from a client that omits writer identity. The [Iceberg spec](https://github.com/apache/iceberg/blob/main/format/spec.md) defines snapshot summary keys for identifying the engine that wrote the snapshot: | Key | Description | | --- | --- | | `engine-name` | Name of the engine that created the snapshot | | `engine-version` | Version of the engine that created the snapshot | | `iceberg-version` | Version of the Iceberg library that created the snapshot. Not a spec field; Java and Go write it | Other implementations already write these, or part of them: - Iceberg Java and Iceberg Go copy an environment context into the snapshot summary. That includes `iceberg-version`, and an engine can also set `engine-name` and `engine-version`. [apache/iceberg#9273](https://github.com/apache/iceberg/pull/9273), [apache/iceberg-go#1680](https://github.com/apache/iceberg-go/pull/1680) - PyIceberg writes `engine-name` and `engine-version`. [apache/iceberg-python#3441](https://github.com/apache/iceberg-python/pull/3441) ### Describe the solution you'd like On every snapshot iceberg-rust commits, set: - `engine-name` to `iceberg-rust` when the caller did not set it - `engine-version` to the `iceberg` crate version when the caller did not set it - `iceberg-version` to `Apache Iceberg Rust <crate version>`, always `engine-name` and `engine-version` stay when `set_snapshot_properties` already supplied them, so an embedding engine can record itself. `iceberg-version` is this library's identity and replaces a caller value. Other caller properties are unchanged. Existing snapshots are left alone. ### Willingness to contribute I can contribute to this feature independently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
