Dzeri96 commented on PR #17029: URL: https://github.com/apache/iceberg/pull/17029#issuecomment-6026674145
@RussellSpitzer In the end I decided against writing any tests for this. I figure, if someone wants to change this one specific line, they probably understand what they are doing. I guess this is now ready to merge. While I have you here, could you take a look at #18221 from a philosophical perspective? If we decide to go ahead with it, I will re-write the tests there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
