rdblue commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r4200427048
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -692,10 +1143,14 @@ private static PartitionData partition(String category) {
/** Minimal file with no tracking, used by the rejection and null-tracking
tests. */
private static TrackedFileStruct dummyTrackedFile(FileContent contentType) {
+ return dummyTrackedFile(contentType, FORMAT_VERSION_V4);
+ }
+
+ private static TrackedFileStruct dummyTrackedFile(FileContent contentType,
int formatVersion) {
Review Comment:
Minor: Why "dummy" here but almost nowhere else? I don't think this naming
convention is a good one. Dummy is not telling the reader anything significant.
And in fact, it is misleading because this creates a `TrackedFileStruct` rather
than something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
