Revanth14 commented on PR #2046: URL: https://github.com/apache/iceberg-go/pull/2046#issuecomment-6030348855
Hey @badalprasadsingh #2099 (merged) registers a conflict validator in `performCopyOnWriteDeletion` over `removed`, built from `filesToDelete` and `filesToRewrite`. Since this PR turns `filesToRewrite` into `entriesToRewrite []iceberg.ManifestEntry`, you'll need to build `removed` from the entries' `DataFile()` when you rebase. The compiler will flag it. #2140 also touches that line (it switches to `slices.Concat`), so whichever of the two lands second will need a small adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
