findinpath commented on code in PR #18338:
URL: https://github.com/apache/iceberg/pull/18338#discussion_r4203101794
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -413,6 +413,16 @@ private static boolean requireStatsProjection(Expression
rowFilter, Collection<S
&& !columns.containsAll(STATS_COLUMNS);
}
+ private F withFilterableStats(F contentFile) {
+ if (contentFile.content() == FileContent.EQUALITY_DELETES
+ && !contentFile.equalityFieldIds().isEmpty()) {
+ // only equality delete's equality-field stats are relevant for pruning
+ return
contentFile.copyWithStats(Set.copyOf(contentFile.equalityFieldIds()));
Review Comment:
Makes sense - I've added
org.apache.iceberg.expressions.InclusiveMetricsEvaluator#statsForColumns in
`InclusiveMetricsEvaluator`. Thank you for the hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]