abhishekmauryaKsolves commented on PR #18337: URL: https://github.com/apache/iceberg/pull/18337#issuecomment-6031277951
> 1-4 LGTM. Regarding the question, I'm fine either way, with a slight preference to the option "a" to avoid a window. Thanks @ggershinsky. Went with option (a): HiveTableOperations now reads encryption.kms-key-generation-enabled from the HMS table parameters on refresh, includes it in the metadata integrity check, and falls back to the metadata file only when creating a table. Added TestHiveTableEncryption covering created table, loaded table, default (wrap) and HMS-only parameter cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
