CaptainAni187 commented on PR #2109: URL: https://github.com/apache/iceberg-go/pull/2109#issuecomment-6031673981
@zeroshade Thanks, done in dbd1421. Build now only guarantees what it does to the logs. - `lastUpdatedMS` stays cached on the builder, with your comment. - The view UUID is generated per build again, and the tests no longer assert that UUIDs match. - `TestBuild_FromBaseDoesNotGrowVersionLog` uses a three-entry base log with a history size of 2. It checks `[3, 4]` on each of three builds and that the builder keeps its three entries. - `TestSnapshotLogAfterMovingMainBackAfterBuild` pins the `[A, A]` sequence, and the description now mentions it. The new tests fail on main. @laskoviymishka this undoes the timestamp and UUID parts of my previous commit, following the threads above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
