grantatspothero commented on code in PR #18359:
URL: https://github.com/apache/iceberg/pull/18359#discussion_r4208268494
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -493,6 +495,8 @@ private Collection<DeleteFile> loadDeleteFiles() {
// read all of the matching delete manifests in parallel and accumulate
the matching files in
// a queue
Queue<DeleteFile> files = new ConcurrentLinkedQueue<>();
+ // share one location instance across deletes that reference the same
data file
+ Map<String, String> referencedDataFiles = Maps.newConcurrentMap();
Review Comment:
consider breaking referenced data file location caching change into separate
commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
