openinx commented on a change in pull request #2064:
URL: https://github.com/apache/iceberg/pull/2064#discussion_r560663819
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/FlinkCatalogTestBase.java
##########
@@ -101,17 +101,24 @@ public FlinkCatalogTestBase(String catalogName, Namespace
baseNamespace) {
}
if (isHadoopCatalog) {
config.put(FlinkCatalogFactory.ICEBERG_CATALOG_TYPE, "hadoop");
- config.put(CatalogProperties.WAREHOUSE_LOCATION, "file://" +
hadoopWarehouse.getRoot());
} else {
config.put(FlinkCatalogFactory.ICEBERG_CATALOG_TYPE, "hive");
- config.put(CatalogProperties.WAREHOUSE_LOCATION, "file://" +
hiveWarehouse.getRoot());
config.put(CatalogProperties.HIVE_URI, getURI(hiveConf));
}
+ config.put(CatalogProperties.WAREHOUSE_LOCATION,
String.format("file://%s", warehouseRoot()));
Review comment:
It's not a fix, just for abstraction, so that we could get all data
files under the given partition here:
https://github.com/apache/iceberg/pull/2064/files#diff-0aaa93576853d5b379da121bc5d6161eb888fe15b88e3597374ed894d8c94917R275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
