huaxingao commented on code in PR #18210:
URL: https://github.com/apache/iceberg/pull/18210#discussion_r4213209954
##########
aliyun/src/main/java/org/apache/iceberg/aliyun/AliyunClientFactory.java:
##########
@@ -31,6 +32,13 @@ public interface AliyunClientFactory extends Serializable {
*/
OSS newOSSClient();
+ /**
+ * Create an aliyun KMS client.
+ *
+ * @return kms client.
+ */
+ Client newKmsClient();
Review Comment:
Nit: since `AliyunClientFactory` can be replaced through
`client.factory-impl`, could this have a default implementation (e.g. throwing
`UnsupportedOperationException`) so existing custom factories keep compiling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
