C-Loftus commented on PR #2125:
URL: https://github.com/apache/iceberg-go/pull/2125#issuecomment-6051422803
Oh one other comment I forgot
I called out the read-side change in the description and added
TestGeoParquetReadWithoutStoredSchema, which writes a GEOMETRY(srid:4326) file
with no stored Arrow schema and covers:
- reads_as_geoarrow.wkb: reads as geoarrow.wkb / geometry(srid:4326)
- projects_onto_geometry_column: projects onto a geometry column cleanly
- binary_column_rejects_it: a binary column fails with cannot promote
geometry(srid:4326) to binary
- AddFiles_schema_check_rejects_binary_column: FileToDataFile rejects a
binary table schema
On the previous geoarrow-go pin these are reversed: the file reads as
binary, the geometry projection fails, and the binary cases succeed. The test
pins the current behavior for now; if it is reasonable to you, to reduce the
scope of this PR, can we align on whether geometry should project onto a binary
column in a follow-up issue rather than in this bump? It might make sense to
get some opinions on that and I'd prefer this PR not getting out of date and
needing to be refactored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
