mxm commented on code in PR #18356:
URL: https://github.com/apache/iceberg/pull/18356#discussion_r4218023165


##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestTableUpdater.java:
##########
@@ -431,4 +479,38 @@ void testTableCreationWithExistingNamespace() {
     assertThat(result.f0.resolvedTableSchema().sameSchema(SCHEMA)).isTrue();
     
assertThat(result.f0.compareResult()).isEqualTo(CompareSchemasVisitor.Result.SAME);
   }
+
+  private static InMemoryCatalog catalogWithEmptyTable() {

Review Comment:
   We typically use a junit extension for catalog access in the tests. See the 
other tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to