rdblue commented on code in PR #17918: URL: https://github.com/apache/iceberg/pull/17918#discussion_r4221955297
########## format/spec.md: ########## @@ -241,6 +242,8 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-value pairs with a key type and a value type. Both the key field and value field each have an integer id that is unique in the table schema. Map keys are required and map values can be either optional or required. Both map keys and map values may be any type, including nested types. +A **`file`** is a tuple with explicitly defined [nested fields](#file-type) representing a range of bytes stored inline as a value or as a reference to an external file. The structure of this type is immutable. Nested fields are referenced by offset from the field ID assigned to the enclosing type, not represented directly in the schema. Review Comment: Minor: I'd prefer to state what the type represents before outlining its storage. > A **`file`** stores a binary value, either inline or as a reference to a section of an external file. The structure of this type is a fixed set of [nested fields](#file-type). These fields are referenced by offset from the field ID assigned to the encoding type, not represented directly in the schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
