NoahKusaba commented on PR #3372: URL: https://github.com/apache/iceberg-rust/pull/3372#issuecomment-6074214574
@comphead thanks for the review, all addressed in db9d1a5f6: - Dropped `test_rerun_finds_its_key_below_later_snapshots`. `test_append_without_files_records_its_key` is replaced (see the zero-file thread), so the full summary-map assertion is gone too. - Added `test_skipped_append_keeps_the_other_updates`: a property update in the same transaction still commits when the append is skipped. - A skip now logs `tracing::info!` with the key and the snapshot ID that holds it. - Renamed `snapshot_properties()` to `summary_properties()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
