xanderbailey commented on code in PR #3334:
URL: https://github.com/apache/iceberg-rust/pull/3334#discussion_r4229016543
##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -379,7 +379,10 @@ pub(crate) mod _serde {
};
match self {
RawLiteralEnum::Null => Ok(None),
- RawLiteralEnum::Boolean(v) => Ok(Some(Literal::bool(v))),
+ RawLiteralEnum::Boolean(v) => match ty {
+ Type::Primitive(PrimitiveType::Boolean) =>
Ok(Some(Literal::bool(v))),
+ _ => Err(invalid_err("boolean")),
Review Comment:
This is the right place for the check: both Datum deserialization forms and
nested JSON/Avro literals pass through here. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
