anoopj commented on code in PR #3328:
URL: https://github.com/apache/iceberg-rust/pull/3328#discussion_r4234048267
##########
crates/iceberg/src/expr/visitors/page_index_evaluator.rs:
##########
@@ -455,6 +544,40 @@ impl<'a> PageIndexEvaluator<'a> {
}
}
+ /// Converts a `FIXED_LEN_BYTE_ARRAY` decimal page bound into a [`Datum`].
+ /// Parquet stores Iceberg decimals with precision > 18 as big-endian
+ /// two's-complement `FIXED_LEN_BYTE_ARRAY` of width `type_length`.
+ ///
+ /// Returns an error for a bound whose width differs from `type_length`:
that
Review Comment:
In the followup, I reworded the helper doc and the inline arm comment to
frame the guard as defence against a non-conforming writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
