TGooch44 commented on a change in pull request #2115:
URL: https://github.com/apache/iceberg/pull/2115#discussion_r561241305
##########
File path: python/iceberg/api/partition_spec.py
##########
@@ -117,9 +118,9 @@ def compatible_with(self, other):
def lazy_fields_by_source_id(self):
if self.fields_by_source_id is None:
- self.fields_by_source_id = dict()
+ self.fields_by_source_id = defaultdict(list)
for field in self.fields:
- self.fields_by_source_id[field.source_id] = field
+ self.fields_by_source_id[field.source_id].append(field)
Review comment:
at the very least, I will add some test coverage, but it may be
worthwhile looking at the change more critically in general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
