sfc-gh-rbachala opened a new issue, #2168: URL: https://github.com/apache/iceberg-go/issues/2168
### Context In #2165 the catalog conformance suite gained rename tests gated by `SupportsRenameTable`. When a catalog sets this to `false`, the rename tests are currently skipped entirely via `t.Skip()`. As noted in [review feedback](https://github.com/apache/iceberg-go/pull/2165#pullrequestreview-2891217063), this means a half-implemented or regressed rename on a catalog that claims not to support it stays green — there's no assertion that the catalog actually returns a "not supported" error. ### Proposal 1. Add a sentinel error (e.g., `catalog.ErrNotImplemented` or `catalog.ErrUnsupported`) to the catalog package. 2. When `SupportsRenameTable` is `false`, instead of skipping, assert that `RenameTable` returns that sentinel. 3. Consider applying the same pattern to other `Supports*` flags as they're added to the conformance suite. This makes "unsupported" a verified behavior rather than an untested assumption. ### Related - #2165 — table lifecycle conformance tests - #1097 — Hadoop catalog rename support (referenced in review as the eventual flip point) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
