advancedxy commented on code in PR #956:
URL: https://github.com/apache/iceberg-cpp/pull/956#discussion_r4236057646
##########
src/iceberg/expression/predicate.cc:
##########
@@ -247,6 +249,19 @@ bool IsFloatingType(TypeId type) {
return type == TypeId::kFloat || type == TypeId::kDouble;
}
+bool AllAncestorsRequired(const StructType& struct_type, const BoundReference&
ref) {
Review Comment:
this matches the fix in iceberg-java side:
https://github.com/apache/iceberg/pull/14270 and I think it deserve a separate
PR for this fix. I noticed this problem when fixing
https://github.com/apache/iceberg-cpp/pull/967 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
