dgvj-work opened a new pull request, #2170: URL: https://github.com/apache/iceberg-go/pull/2170
## Summary Stacked on #2169. The planning commit is already in that PR; this PR adds the commit that reads the planned file-level changes. - `IncrementalChangelogScan.Read` and `ToArrowRecords` read `AddedRowsScanTask` and `DeletedDataFileScanTask` through the existing scan, then append `_change_type`, `_change_ordinal`, and `_commit_snapshot_id`. - Deletes already stored on those tasks are applied first, so a removed data file does not emit rows that were already deleted, and an added data file does not emit rows removed by same-snapshot deletes. - `DeletedRowsScanTask` returns `ErrNotImplemented`. A plan that includes row-level deletes fails instead of dropping those rows. Emitting them is the next PR. This does not close #1884. ## Test plan - [x] `go test ./table -count=1 -run 'TestChangelogRead|TestIncrementalChangelogRead'` - [x] `golangci-lint run --new-from-rev=feat/changelog-delete-file-planning ./table/` - [ ] Review the reader commit after #2169. File add/remove, projection, row filter, and limit are covered. Row-level position, equality, and deletion-vector deletes are not read yet. Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
