szehon-ho commented on code in PR #17957:
URL: https://github.com/apache/iceberg/pull/17957#discussion_r4237386588
##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -158,6 +173,118 @@ public Set<TableCapability> capabilities() {
return capabilities;
}
+ @Override
+ public boolean supportsColumnChange(TableChange.ColumnChange change) {
Review Comment:
Optional: Could we move the schema-evolution checks and lazy map-key index
into a package-private `SparkSchemaEvolution` helper in this package, leaving
`supportsColumnChange` as a delegate? This would group the rules and make them
easier to unit-test directly. There’s precedent for stateful helpers such as
`SparkMicroBatchPlanner` and `SparkConfParser`, though keeping these checks
here is also reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
