richiebachala commented on issue #1691: URL: https://github.com/apache/iceberg-go/issues/1691#issuecomment-6099420197
Quick follow-up on the Polaris question above, now that #2165 is approved and #2173 (cross-namespace rename tests, stacked on it) is up in draft. Running `catalogtest` against a second REST implementation is where the suite earns its keep: #2165's rename-to-existing 409 fix and #2173's missing-namespace 404 fix are both client-side divergences that one fixture alone could mask. Polaris currently passes the full suite. Two options: 1. **Add a Polaris service to `internal/recipe/docker-compose.yml`** and run REST conformance against it in the integration job. 2. **Keep it opt-in** via `POLARIS_URI`, documented in CONTRIBUTING, so it costs CI nothing. I lean toward (1) for the coverage, but (2) avoids adding another image to every integration run. @zeroshade @laskoviymishka, any preference? I'll pick it up after #2173 either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
