DengYiping commented on PR #18392: URL: https://github.com/apache/iceberg/pull/18392#issuecomment-6099520446
> Great catch! LGTM (non-binding). > > Two small nits, neither blocking: > > * The uniqueValue javadoc should mention that the term must be non-null preserving. > * testStringNotStartsWith now only has "read" assertions, and one message still says "should skip". Good feedback. Both fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
