manuzhang opened a new pull request, #999:
URL: https://github.com/apache/iceberg-cpp/pull/999

   When a source column has been dropped from the current schema, 
`PartitionSpec::PartitionType` currently assigns `unknown` to all partition 
fields referencing it. This loses the known result types of fixed-result 
transforms and prevents older manifest bounds from being decoded correctly.
   
   Always ask the transform for its result type, passing `unknown` when the 
source is absent. Bucket and year fields retain `int32`, and day fields retain 
`date`; identity fields remain `unknown`. Extend `PartitionTypeMissingSource` 
to cover dropped bucket, day, year and identity sources.
   
   Extracted from #876 as an independent prerequisite for its metadata-table 
work.
   
   Validation: pre-commit and `git diff --check` passed; the standalone 
`schema_test` suite passed all 561 tests. The expanded 
`PartitionTypeMissingSource` regression fails against the previous 
implementation for dropped bucket/day/year fields and passes with the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to