Revanth14 commented on code in PR #2163:
URL: https://github.com/apache/iceberg-go/pull/2163#discussion_r4238807264
##########
catalog/rest/vended_creds.go:
##########
@@ -474,6 +486,26 @@ func clearOverriddenCredentialProperties(props,
credentialConfig iceberg.Propert
delete(props, keyAdlsSasExpiresAtMs+"."+suffix)
}
}
+
+ if credentialConfig[iceio.ADLSToken] != "" {
Review Comment:
Fixed. Only the matched account's SAS and connection string are cleared now,
and the comment is corrected. The shared key is still always cleared, because
the factory applies it to every account and B's key would sign A's requests.
The table-wide IO is also bound to the metadata location's account
(`ErrUnsupportedObjectAuthority` for any other), so it never reads account B
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
