richiebachala opened a new pull request, #2173: URL: https://github.com/apache/iceberg-go/pull/2173
Follow-up to #2165, addressing @laskoviymishka's suggestion to cover the rename paths most likely to hide cross-catalog divergence. Part of #1691. > **Stacked on #2165.** This branch includes its commits; only the last commit (`658efca`) is new. I'll rebase onto `main` once #2165 merges and mark this ready for review then. ## Changes - **`RenameTableAcrossNamespaces`**: a table moves to another namespace, keeps its UUID, and is listed only in the destination. - **`RenameTableToMissingNamespace`**: renaming into a nonexistent namespace returns `ErrNoSuchNamespace` and leaves the source table in place. - **REST fix**: the spec's rename 404 covers both a missing source table and a missing destination namespace, and the client mapped every 404 to `ErrNoSuchTable`. It now discriminates on `error.type`, following the existing `loadFunction` pattern, so a missing namespace reports `ErrNoSuchNamespace`, matching Hive and SQL. Unit tests cover both 404 types. The new conformance test caught the REST divergence: against the Java REST fixture, the server returns `NoSuchNamespaceException`, which the client previously reported as a missing table. ## Testing - `go test ./catalog/...` - Conformance for SQL and Hadoop, plus REST and Hive with `-tags integration` against `internal/recipe` containers: all pass, including both new cases. - `golangci-lint`: 0 issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
