amogh-jahagirdar commented on code in PR #18427:
URL: https://github.com/apache/iceberg/pull/18427#discussion_r4239058701
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -1440,14 +1389,14 @@ public void
partitionFilterUpdatesScanMetricsSkipCounts(FileFormat format) throw
assertThat(read(builder))
.usingComparatorForType(FILE_COMPARATOR, TrackedFile.class)
- .containsExactly(FILE_A, EQ_DELETES_A, DATA_MANIFEST_REF,
DELETE_MANIFEST_REF);
+ .containsExactly(FILE_A, DATA_MANIFEST_REF, DELETE_MANIFEST_REF);
assertThat(metrics.skippedDataFiles().value())
.as("one data file is pruned by the partition filter")
.isEqualTo(1L);
assertThat(metrics.skippedDeleteFiles().value())
- .as("one delete file is pruned by the partition filter")
- .isEqualTo(1L);
+ .as("no delete files are present")
+ .isEqualTo(0L);
Review Comment:
Do we need the assertion anymore? Not sure what it's really guarding at this
point because the test doesn't produce an equality delete anymore.
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -205,7 +205,6 @@ private boolean matchesPartition(TrackedFile trackedFile) {
private void incrementSkipCount(TrackedFile file) {
switch (file.contentType()) {
case DATA -> scanMetrics.skippedDataFiles().increment();
- case EQUALITY_DELETES -> scanMetrics.skippedDeleteFiles().increment();
Review Comment:
Separate to this PR: I was looking at `skippedDeleteFiles` looks like this
was the only caller for v4, and now it's going away.
Should DVs that are colocated with data files also lead to incrementing the
skippedDeleteFiles metric as well? that seems consistent to what was happening
with v2/v3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
