JeonDaehong commented on PR #3243: URL: https://github.com/apache/iceberg-rust/pull/3243#issuecomment-6109032865
I compared this with `iceberg-java`. The new expected values match `TestTruncatesProjection` exactly (e.g., `testDecimalStrictLowerBound`: `< 100.00`, `>=` -> `> 99.90`, NOT IN `[99.00, 100.00, 101.00]`; upper bound `[98.90, 99.90, 100.90]`). Keeping the scale on the ±1 boundary is also what `ProjectionUtil` does (`new BigDecimal(unscaled ± 1, scale)`), and the first-W-bytes approach for binary matches `TruncateByteBuffer`. LGTM! **One note:** #3120 (open since 8/31, closes #3119) also adds the `Binary` arm to `Truncate::transform_literal`, so it may be worth linking the two so they don't conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
