advancedxy commented on code in PR #956:
URL: https://github.com/apache/iceberg-cpp/pull/956#discussion_r4244433724
##########
src/iceberg/expression/binder.cc:
##########
@@ -24,6 +24,21 @@
namespace iceberg {
+namespace {
+
+Result<std::optional<bool>> CombineResults(const std::optional<bool>&
left_result,
Review Comment:
This method should be scoped to IsBoundVisitor? CombineBoundResults or make
it a private helper method of IsBoundVisitor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
