openinx commented on a change in pull request #1936:
URL: https://github.com/apache/iceberg/pull/1936#discussion_r561531089
##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
##########
@@ -70,6 +73,7 @@ public static Builder forRowData() {
private Table table;
private TableLoader tableLoader;
private TableSchema projectedSchema;
+ private ReadableConfig flinkConf;
Review comment:
Got your point, I'd prefer to use flink's `Configuration` because it
will be exposed to flink developers as an API in `FlinkSource`, using the
unified `Configuration` will be more straightforward for them. But as you
said, the TableSourceFactory#Context is exposing the `ReadableConfig`, I
also did not find a correct way to convert `ReadableConfig` to `Configuration`.
OK, I think we could use `ReadableConfig` here, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
