wombatu-kun commented on code in PR #16655:
URL: https://github.com/apache/iceberg/pull/16655#discussion_r4244687075
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/SinkWriter.java:
##########
@@ -39,12 +40,16 @@ public class SinkWriter {
private final IcebergWriterFactory writerFactory;
private final Map<String, RecordWriter> writers;
private final Map<TopicPartition, Offset> sourceOffsets;
+ // the route field is fixed per config, so split its dotted path once
instead of per record
Review Comment:
Dropped in 23e1b0073a, without a replacement: the null contract is already
stated where the field is read, by the `// route to all tables` branch on the
static path and the `checkNotNull` message on the dynamic one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
