koodin9 commented on PR #18003: URL: https://github.com/apache/iceberg/pull/18003#issuecomment-6118720875
@laskoviymishka Could you take a look at this PR, or point me to the right reviewer? Some context: #14797 (CDC/upsert for the sink) was blocked because it committed equality deletes, and it was closed as stale. Since then, the v4 spec forbids writing new equality deletes (#17783), and Flink converts them to deletion vectors with `ConvertEqualityDeletes` (#17142). This series follows the same direction for Kafka Connect. The coordinator resolves the equality deletes of a commit to row positions and commits deletion vectors instead, so the table never contains an equality delete. This PR (part 1 of 4) only adds the converter class. Nothing calls it yet, so there is no behavior change. Before I continue with the coordinator wiring, is this direction acceptable for the sink, or should I start a `[DISCUSS]` thread on dev@ first? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
