bryanck commented on code in PR #17910:
URL: https://github.com/apache/iceberg/pull/17910#discussion_r4248950933
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Channel.java:
##########
@@ -234,8 +162,10 @@ void start() {
void stop() {
LOG.info("Channel stopping");
- producer.close();
- consumer.close();
- admin.close();
+ // Close the consumer first to prevent stale consumer in the consumer
group if producer close
+ // hangs + add timeouts
Review Comment:
This comment isn't clear to me, could you clarify this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
