rshdhere commented on issue #17804: URL: https://github.com/apache/iceberg/issues/17804#issuecomment-6129814329
Hi @RussellSpitzer, thanks for filing this publicly with such a clear write-up. I checked current `main`, and the WARN in `NessieCatalog.warehouseLocation` still prints the full `catalogOptions` map ([here](https://github.com/apache/iceberg/blob/256f542d3e9f50f97fabf4ffea498f151fb44820/nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java#L205-L210)). I also noticed #17806 tried to fix this, but it was closed by the stale bot before anyone reviewed it. I'd like to pick this up if that's okay. Of the two options you listed, I'd go with the simpler one: keep the WARN (since the Spark path can swallow the exception), but log only the catalog name and the missing `warehouse` property. If there's a clean way to capture the log in the Nessie tests, I'd also add a test showing the options don't appear in it. If you'd rather keep the options in the log with sensitive keys redacted, I'm happy to do that instead. Would you be okay assigning this to me? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
