dhruvarya-db commented on code in PR #3260:
URL: https://github.com/apache/iceberg-rust/pull/3260#discussion_r4251833172
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -282,7 +317,15 @@ impl<'a> TableScanBuilder<'a> {
/// Build the table scan.
pub fn build(self) -> Result<TableScan> {
- let snapshot = match self.snapshot_id {
+ let snapshot_id = match self.snapshot_selection {
+ Some(SnapshotSelection::SnapshotId(id)) => Some(id),
+ Some(SnapshotSelection::AsOfTime(timestamp_ms)) =>
Some(snapshot_id_as_of_time(
Review Comment:
Good point, I have updated the snapshot_selection logic such that we create
the error message in advance when the snapshot_id is resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
