pvary commented on a change in pull request #2046:
URL: https://github.com/apache/iceberg/pull/2046#discussion_r561823663
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTable.java
##########
@@ -186,4 +194,34 @@ public Transaction newTransaction() {
public String toString() {
return name();
}
+
+ abstract Object writeReplace();
Review comment:
Followed your recommendation. LGTM
The thing is that `metadataLocation()` is exactly the same for every
implementation, but we need this if we do not want to relax the `private`
restriction on `ops`. We might be further simplify the code if we move `ops` to
`BaseMetadataTable`.
What do you think? Or it would be a bigger change which do no worth to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
