rshdhere commented on issue #17755: URL: https://github.com/apache/iceberg/issues/17755#issuecomment-6132415882
Hi @aboueleyes, thanks for the clear report and the measurements. That makes the impact really easy to see. I checked current `main` and the loop is unchanged in `listTables`, `listNamespaces` and `listViews` ([e.g. here](https://github.com/apache/iceberg/blob/843d36de699bbbacd1fc317e4ec3d824b600eccd/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L337-L351)). I saw that #17767 and #17818 both tried to fix this but were closed by the stale bot, and that @uros-b asked for coordination there to avoid duplicate work. @waterWang, @dkranchii, are either of you still planning to pick this back up? If so, I'm happy to help review instead. If not, I'd like to take it on: track the tokens already seen in each listing and fail with a clear error when one repeats, plus tests for both the repeated-token case and a normal multi-page listing, which @uros-b pointed out was missing. Does that approach sound reasonable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
