mbutrovich commented on PR #3388: URL: https://github.com/apache/iceberg-rust/pull/3388#issuecomment-6127124907
@comphead, thanks for the review. > Beyond the inline comments, `arrow-avro` is built with `snappy` and `zstd`, but the only external fixture is deflate. One small test per codec would cover the feature flags. I added `test_compressed_manifests`, which re-encodes a manifest with deflate, snappy and zstd and compares each read with the read of the uncompressed manifest. `ManifestWriter` writes uncompressed manifests, so the test re-encodes with apache-avro instead of adding fixture files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
